Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolsPanel: Sets column-gap to 16px for grid #64497

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

amitraj2203
Copy link
Contributor

@amitraj2203 amitraj2203 commented Aug 14, 2024

What?

Closes: #64488

Why?

To update the column gap from 8px to 16px according to the current specs

Screenshots or screencast

image

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: amitraj2203 <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@amitraj2203 amitraj2203 added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Aug 14, 2024
@amitraj2203 amitraj2203 requested a review from mirka August 14, 2024 11:10
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@mirka
Copy link
Member

mirka commented Aug 14, 2024

Oh by the way, please add a changelog before merging 🙏

@mirka mirka changed the title ToolsPanel: Sets column-gap to 4px for grid ToolsPanel: Sets column-gap to 16px for grid Aug 14, 2024
@amitraj2203 amitraj2203 enabled auto-merge (squash) August 15, 2024 13:00
Copy link

Flaky tests detected in f9aa861.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10404117736
📝 Reported issues:

@amitraj2203 amitraj2203 merged commit 8bcd5f0 into trunk Aug 15, 2024
61 checks passed
@amitraj2203 amitraj2203 deleted the feat/issue-64488 branch August 15, 2024 15:23
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToolsPanel grid should have a 16px column gap
2 participants